feat: add self-commands request to server #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppolewicz
reviewed
Sep 28, 2024
src/bt_auto_dumper/_v2/__main__.py
Outdated
Comment on lines
18
to
22
| CODENAME_MAP = { | ||
| "computehorde": ["sn12", "12", "computehorde"], | ||
| "omron": ["sn13", "13", "omron", "Omron"], | ||
| "textprompting": ["sn14", "14", "textprompting"], | ||
| } |
There was a problem hiding this comment.
this has to be retrieved from the autovalidator, should not be hardcoded here
src/bt_auto_dumper/_v2/__main__.py
Outdated
| @@ -57,49 +71,46 @@ def main(apiver: str | None = None): | |||
|
|
|||
| if not (subnet_identifier := args.subnet_identifier) or not (autovalidator_address := args.autovalidator_address): | |||
| autovalidator_address, subnet_identifier = load_config(config_path=config_path) | |||
| dump_and_upload(subnet_identifier, args.subnet_realm, autovalidator_address, args.note) | |||
| filtered_subnet_identifier = re.sub(r"[_\-.]", "", str.lower(subnet_identifier)) | |||
There was a problem hiding this comment.
move this line to normalize_codename()
src/bt_auto_dumper/_v2/__main__.py
Outdated
| @@ -250,5 +263,37 @@ def update_confg(config_path: str, new_autovalidator_address: str, new_codename: | |||
| raise RuntimeError(f"Failed to write to the configuration file: {config_path}.\n Error: {e}") | |||
|
|
|||
|
|
|||
| def request_commands_to_server( | |||
There was a problem hiding this comment.
Suggested change
| def request_commands_to_server( | |
| def request_commands_from_server( |
ppolewicz
reviewed
Oct 3, 2024
ppolewicz
reviewed
Oct 4, 2024
src/bt_auto_dumper/_v2/__main__.py
Outdated
Comment on lines
106
to
108
| logger.info(f"Subnet dumper commands of {subnet_identifier} retrieved successfully. {commands}") | ||
| if not commands: | ||
| print(f"Subnet identifier {subnet_identifier} not found.") | ||
| logger.error(f"Subnet dumper commands of {subnet_identifier} not found.") |
There was a problem hiding this comment.
if there are no commands, both of those logs will be emitted
src/bt_auto_dumper/_v2/__main__.py
Outdated
| @@ -277,46 +283,13 @@ def get_commands_from_server( | |||
| response = make_signed_request("GET", url, headers, "", wallet, subnet_realm) | |||
| if response.status_code == 200: | |||
| data = response.json() | |||
| print(data) | |||
| print("Commands successfully retrieved.") | |||
| logger.info("Commands successfully retrieved.") | |||
There was a problem hiding this comment.
Suggested change
| logger.info("Commands successfully retrieved.") |
this duplicates a log statement from main.py line 106
src/bt_auto_dumper/_v2/__main__.py
Outdated
| commands = get_commands_from_server(subnet_identifier, subnet_realm, wallet, autovalidator_address) | ||
|
|
||
| # get normalized subnet identifier and commands from the central server | ||
| subnet_identifier, commands = get_commands_from_server( |
There was a problem hiding this comment.
according to docstring and return type of get_commands_from_server(), the function only returns commands and does not return a subnet identifier
ppolewicz
reviewed
Oct 8, 2024
src/bt_auto_dumper/_v2/__main__.py
Outdated
|
|
||
| args = parser.parse_args() | ||
|
|
||
| # Get configuration directory from env variable. | ||
| config_base_dir = os.getenv("CONFIG_DIR") | ||
| config_base_dir = os.getenv("CONFIG_DIR", default="") |
There was a problem hiding this comment.
Suggested change
| config_base_dir = os.getenv("CONFIG_DIR", default="") | |
| config_base_dir = os.getenv("CONFIG_DIR", default=`~/.config/bt-auto-dumper`) |
src/bt_auto_dumper/_v2/__main__.py
Outdated
|
|
||
| wallet = bt.wallet(name="validator", hotkey="validator-hotkey", path="~/.bittensor/wallets") |
There was a problem hiding this comment.
these should all be taken from the config, but should have defaults
src/bt_auto_dumper/_v2/__main__.py
Outdated
| wallet | ||
| "/path/test.zip", | ||
| wallet, | ||
| "mainnet" |
There was a problem hiding this comment.
Suggested change
| "mainnet" | |
| "mainnet", |
ppolewicz
approved these changes
Oct 8, 2024
Comment on lines
+59
to
+60
| autovalidator_address, subnet_identifier, __, __, __ = load_config(config_path=config_path) | ||
| __, __, wallet_name, wallet_hotkey, wallet_path = load_config(config_path=config_path) |
There was a problem hiding this comment.
this is not good but I'm so tired of this PR I'll let it slide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the autodetection of bittensor wallet
Fix the commands as list type
Add the feature for requesting commands to auto-validator server