Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve typescript parsing #9

Merged
merged 2 commits into from
Dec 19, 2021
Merged

Conversation

Narretz
Copy link
Collaborator

@Narretz Narretz commented Dec 19, 2021

Ignore nodes that acorn-walk doesn't support.
This should not affect the extraction, because
it / describe are CallExpressions.

Fixes #8

Ignore nodes that acorn-walk doesn't support.
This should not affect the extraction, because
test suites are built only from CallExpressions.

Fixes bahmutov#8
Copy link
Owner

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a pretty slick solution, I am very impressed!
Would you like to maintain this repo with me, so you don't have to ask and could merge the solutions like this one in the future?

@bahmutov bahmutov merged commit 6d824ee into bahmutov:main Dec 19, 2021
@github-actions
Copy link

🎉 This PR is included in version 1.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Narretz
Copy link
Collaborator Author

Narretz commented Dec 20, 2021

Hey, great that you like the PR!
Happy to be co-maintainer, thanks for the invitation!

@Narretz Narretz deleted the fix-typescript branch December 20, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem walking parsed TS spec code
2 participants