patch: fix type error by extending AddLiquidity class

balancer · Jan 25, 2025 · e8e5abc · e8e5abc
1 parent 2ae3ba2
commit e8e5abc
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/src/entities/addLiquidity/index.ts b/src/entities/addLiquidity/index.ts
@@ -17,7 +17,7 @@ import { Hex } from 'viem';
 
 export class AddLiquidity implements AddLiquidityBase {
     constructor(public config?: AddLiquidityConfig) {}
-    private readonly inputValidator: InputValidator = new InputValidator();
+    protected readonly inputValidator: InputValidator = new InputValidator();
 
     query(
         input: AddLiquidityInput,

diff --git a/src/entities/addLiquidityBoosted/index.ts b/src/entities/addLiquidityBoosted/index.ts
@@ -32,18 +32,15 @@ import {
     balancerRouterAbi,
 } from '@/abi';
 
-import { InputValidator } from '../inputValidator/inputValidator';
-
 import { Hex } from '@/types';
 import {
     AddLiquidityBoostedBuildCallInput,
     AddLiquidityBoostedInput,
     AddLiquidityBoostedQueryOutput,
 } from './types';
+import { AddLiquidity } from '../addLiquidity';
 
-export class AddLiquidityBoostedV3 {
-    private readonly inputValidator: InputValidator = new InputValidator();
-
+export class AddLiquidityBoostedV3 extends AddLiquidity {
     async query(
         input: AddLiquidityBoostedInput,
         poolState: PoolStateWithUnderlyings,

diff --git a/test/v3/removeLiquidityBoosted/removeLiquidityBoosted.integration.test.ts b/test/v3/removeLiquidityBoosted/removeLiquidityBoosted.integration.test.ts
@@ -102,7 +102,6 @@ describe('remove liquidity test', () => {
         });
         snapshot = await client.snapshot();
 
-        // Approve the Vault to spend Tokens on the users behalf via Permit2
         for (const token of boostedPool_USDC_USDT.tokens) {
             await approveSpenderOnPermit2(
                 client,
@@ -126,7 +125,7 @@ describe('remove liquidity test', () => {
 
         await doAddLiquidity({
             client,
-            addLiquidity: new AddLiquidityBoostedV3(), // TODO: debug linter type complaint
+            addLiquidity: new AddLiquidityBoostedV3(),
             addLiquidityInput,
             slippage: Slippage.fromPercentage('1'),
             poolState: boostedPool_USDC_USDT,