Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong composable stable #581

Merged
merged 8 commits into from
Feb 4, 2025
Merged

Conversation

johngrantuk
Copy link
Member

No description provided.

@agualis agualis changed the title Debug/wrong composable stable fix: wrong composable stable Feb 4, 2025
@@ -244,3 +260,66 @@ const deepPoolState: NestedPoolState = {
},
],
};

const nestedOPoolState = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brunoguerios I just created a quick test but naming should be adapted to better express the intention of the test. Could you improve it please?

Copy link
Member

@brunoguerios brunoguerios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

underlyingToken:
t.underlyingToken === null
? null
: { ...t.underlyingToken, index: t.index },
underlyingToken: null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👏

@brunoguerios brunoguerios merged commit 4f07d19 into main Feb 4, 2025
4 checks passed
@brunoguerios brunoguerios deleted the debug/wrongComposableStable branch February 4, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants