Generate a typedesc instruction once for record and tuple types

bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/TypeChecker.java

@@ -544,6 +544,11 @@ public static Object getAnnotValue(TypedescValue typedescValue, BString annotTag
         if (!(describingType instanceof BAnnotatableType)) {
             return null;
         }
+        if (typedescValue instanceof TypedescValueImpl && ((TypedescValueImpl) typedescValue).annotations != null) {
+            if (((TypedescValueImpl) typedescValue).annotations.containsKey(annotTag)) {
+                return ((TypedescValueImpl) typedescValue).annotations.get(annotTag);
+            }
+        }
         return ((BAnnotatableType) describingType).getAnnotation(annotTag);
     }
 
@@ -2151,7 +2156,7 @@ private static boolean checkIsNeverTypeOrStructureTypeWithARequiredNeverMember(T
     private static boolean checkIsLikeType(List<String> errors, Object sourceValue, Type targetType,
                                            List<TypeValuePair> unresolvedValues,
                                            boolean allowNumericConversion, String varName) {
-        Type sourceType = getType(sourceValue);
+        Type sourceType = getImpliedType(getType(sourceValue));
         if (checkIsType(sourceType, targetType, new ArrayList<>())) {
             return true;
         }

bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/types/BTypeReferenceType.java

@@ -47,6 +47,11 @@ public BTypeReferenceType(String typeName, Module pkg, int typeFlags, boolean re
         this.readOnly = readOnly;
     }
 
+    public BTypeReferenceType(Type referredType, boolean readOnly) {
+        this(referredType.getName(), referredType.getPkg(), (int) referredType.getFlags(), readOnly);
+        setReferredType(referredType);
+    }
+
     public void setReferredType(Type referredType) {
         this.referredType = referredType;
     }

bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/util/RuntimeUtils.java

@@ -29,6 +29,7 @@
 import io.ballerina.runtime.internal.TypeConverter;
 import io.ballerina.runtime.internal.diagnostics.RuntimeDiagnosticLog;
 import io.ballerina.runtime.internal.types.BArrayType;
+import io.ballerina.runtime.internal.types.BIntersectionType;
 import io.ballerina.runtime.internal.values.ArrayValue;
 import io.ballerina.runtime.internal.values.ArrayValueImpl;
 import io.ballerina.runtime.internal.values.ErrorValue;
@@ -247,4 +248,11 @@ private static boolean isInvalidBallerinaValue(Object value) {
 
     private RuntimeUtils() {
     }
+
+    public static Type getEffectiveType(Type type) {
+        if (type.getTag() == TypeTags.INTERSECTION_TAG) {
+            return ((BIntersectionType) type).getEffectiveType();
+        }
+        return type;
+    }
 }

bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/values/MapValueImpl.java

@@ -70,6 +70,7 @@
 import static io.ballerina.runtime.internal.errors.ErrorReasons.INVALID_UPDATE_ERROR_IDENTIFIER;
 import static io.ballerina.runtime.internal.errors.ErrorReasons.MAP_KEY_NOT_FOUND_ERROR;
 import static io.ballerina.runtime.internal.errors.ErrorReasons.getModulePrefixedReason;
+import static io.ballerina.runtime.internal.util.RuntimeUtils.getEffectiveType;
 import static io.ballerina.runtime.internal.util.StringUtils.getExpressionStringVal;
 import static io.ballerina.runtime.internal.util.StringUtils.getStringVal;
 import static io.ballerina.runtime.internal.values.ReadOnlyUtils.handleInvalidUpdate;
@@ -303,8 +304,8 @@ public void populateInitialValue(K key, V value) {
             putValue(key, value);
         } else {
             BString fieldName = (BString) key;
-            if (MapUtils.handleInherentTypeViolatingRecordUpdate(this, fieldName, value, (BRecordType) referredType,
-                    true)) {
+            if (MapUtils.handleInherentTypeViolatingRecordUpdate(this, fieldName, value,
+                                          (BRecordType) getEffectiveType(referredType), true)) {
                 putValue(key, value);
             }
         }

bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/values/TypedescValueImpl.java

@@ -28,11 +28,13 @@
 import io.ballerina.runtime.api.values.BTypedesc;
 import io.ballerina.runtime.internal.scheduling.Strand;
 import io.ballerina.runtime.internal.types.BAnnotatableType;
+import io.ballerina.runtime.internal.types.BTypeReferenceType;
 import io.ballerina.runtime.internal.types.BTypedescType;
 
 import java.util.Map;
 
 import static io.ballerina.runtime.api.utils.TypeUtils.getImpliedType;
+import static io.ballerina.runtime.internal.util.RuntimeUtils.getEffectiveType;
 
 /**
  * <p>
@@ -102,6 +104,11 @@ public Object instantiate(Strand s, BInitialValueEntry[] initialValues) {
         } else if (referredType.getTag() == TypeTags.TUPLE_TAG) {
             return new TupleValueImpl(this.describingType, (BListInitialValueEntry[]) initialValues, this);
         }
+        Type effectiveType = getEffectiveType(referredType);
+        if (effectiveType.getTag() == TypeTags.TUPLE_TAG) {
+            return new TupleValueImpl(new BTypeReferenceType(effectiveType, true),
+                                      (BListInitialValueEntry[]) initialValues);
+        }
         // This method will be overridden for user-defined types, therefore this line shouldn't be reached.
         throw ErrorCreator.createError(StringUtils.fromString(
                 "Given type can't be instantiated at runtime : " + this.describingType));