Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert semtype changes #43742

Conversation

chiranSachintha
Copy link
Member

Purpose

$title.

Fixes #

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

…iri/fix/semtype-sycn"

This reverts commit 109f6cc, reversing
changes made to a1e03c5.
…iri/fix/bdd-optim"

This reverts commit 0c01583, reversing
changes made to 9b642cc.
…atform/nutcracker"

This reverts commit f762dae, reversing
changes made to fc33b75.
…tha/perf_fix_semtype"

This reverts commit fbb3a35, reversing
changes made to 109f6cc.
@chiranSachintha chiranSachintha added the Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. label Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 84.24779% with 89 lines in your changes missing coverage. Please review.

Project coverage is 77.40%. Comparing base (e01fe53) to head (8996d17).
Report is 14 commits behind head on 2201.11.0-stage.

Files with missing lines Patch % Lines
.../ballerinalang/compiler/BIRPackageSymbolEnter.java 76.40% 15 Missing and 6 partials ⚠️
...a/io/ballerina/runtime/internal/TypeConverter.java 31.57% 11 Missing and 2 partials ⚠️
...2/ballerinalang/compiler/bir/emit/TypeEmitter.java 52.63% 8 Missing and 1 partial ⚠️
...allerina/runtime/internal/types/BFunctionType.java 50.00% 2 Missing and 4 partials ⚠️
.../io/ballerina/runtime/internal/types/BAnyType.java 76.47% 4 Missing ⚠️
...ler/api/impl/symbols/BallerinaUnionTypeSymbol.java 77.77% 1 Missing and 3 partials ⚠️
...ballerinalang/compiler/bir/codegen/JvmCastGen.java 57.14% 2 Missing and 1 partial ⚠️
...io/ballerina/runtime/internal/types/BByteType.java 60.00% 2 Missing ⚠️
.../ballerina/runtime/internal/types/BHandleType.java 60.00% 2 Missing ⚠️
...allerina/runtime/internal/types/BReadonlyType.java 66.66% 2 Missing ⚠️
... and 20 more
Additional details and impacted files
@@                  Coverage Diff                  @@
##             2201.11.0-stage   #43742      +/-   ##
=====================================================
+ Coverage              77.22%   77.40%   +0.17%     
+ Complexity             58799    58608     -191     
=====================================================
  Files                   3527     3446      -81     
  Lines                 221752   219182    -2570     
  Branches               28815    28972     +157     
=====================================================
- Hits                  171250   169647    -1603     
+ Misses                 40841    40104     -737     
+ Partials                9661     9431     -230     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@warunalakshitha warunalakshitha merged commit 6ec7360 into ballerina-platform:2201.11.0-stage Jan 9, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants