Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensures no conversions to String take place #1

Closed
wants to merge 1 commit into from
Closed

Ensures no conversions to String take place #1

wants to merge 1 commit into from

Conversation

cleberz
Copy link

@cleberz cleberz commented Oct 7, 2018 •
edited
Loading

This commit ensures no conversions to String take place and wiped out intermediate char arrays.

@cleberz cleberz changed the title Ensures no conversions to String take place and wiped out intermediate Ensures no conversions to String take place Oct 7, 2018
@bannmann
Copy link
Owner

bannmann commented Oct 9, 2018

Hi cleberz! You got the wrong project, please direct your PRs to wg/scrypt instead of my fork.

@bannmann bannmann closed this Oct 9, 2018
@cleberz
Copy link
Author

cleberz commented Oct 9, 2018

Hello @bannmann , I merged it intentionally to yours as I couldn't figure out how to issue a PR on top of your PR at wg#33 . Is such thing possible in Github? (I want to make sure I'm not getting credit for your code since mine is based off yours).
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cleberz @bannmann