[epociask/issue-160-slack-fix] Addressing PR feedback

base-org · Oct 20, 2023 · 6e20b7d · 6e20b7d
1 parent 5b124d0
commit 6e20b7d
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/internal/client/slack.go b/internal/client/slack.go
@@ -19,6 +19,10 @@ import (
 	"github.com/base-org/pessimism/internal/logging"
 )
 
+const (
+	msgOK = "ok"
+)
+
 type SlackClient interface {
 	AlertClient
 }
@@ -82,7 +86,7 @@ type SlackAPIResponse struct {
 // ToAlertResponse ... Converts a slack API response to an alert API response
 func (a *SlackAPIResponse) ToAlertResponse() *AlertAPIResponse {
 	status := core.SuccessStatus
-	if a.Message != "ok" {
+	if a.Message != msgOK {
 		status = core.FailureStatus
 	}
 
@@ -132,10 +136,10 @@ func (sc slackClient) PostEvent(ctx context.Context, event *AlertEventTrigger) (
 	}
 
 	// 3.c. validate response body
-	if string(bytes) == "ok" {
+	if string(bytes) == msgOK {
 		return &AlertAPIResponse{
 			Status:  core.SuccessStatus,
-			Message: "ok",
+			Message: msgOK,
 		}, nil
 	}