This repository has been archived by the owner on May 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pociask/issue-141-resilient-pipes
…pociask/large-withdrawal-poc
…pociask/large-withdrawal-poc
…pociask/large-withdrawal-poc
adrain-cb
reviewed
Nov 1, 2023
adrain-cb
approved these changes
Nov 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Withdrawal Safety Heuristic
Fixes Issue
Fixes #
Changes proposed
withdrawal_enforcement
in favor ofwithdrawal_safety
that performs more invariant checks within the heuristicActivationSet
type thats returned for every heuristic assessment operation..devnet
allocations to the main repo to avoid having to build them for running E2E testing. Any regressions from this will be fixed in [issue-172] Version pinned devnet allocations #175withdrawal_safety
operationScreenshots (Optional)
Note to reviewers
Most changes in this PR are the result of
.devnet
being stored locally