Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider defn name metadata for internal processing #1188

Closed
wants to merge 1 commit into from

Conversation

ikappaki
Copy link
Contributor

HI,

can you please consider patch to enable defn to process name metadata alongside map-attr?. It partly addresses #1178 by allowing defasync to effectively pass meta keys such as :decorators for consideration in defn.

While the actual code change is small, it introduces :decorators tests for defn and defasync, which were previously missing. These tests will help lay the groundwork for the next part: supporting the :decorators meta key for fn.

I've also made a minor adjustement to the defn docstring to make it more obvious that the :decorations key is not only defined over attr-map?.

Thanks

Also added tests for decorators meta keys
@ikappaki
Copy link
Contributor Author

This code change turned out to be unnecessary after moving :decorators support to anonymous fn, so I will close it and migrate the tests to the later PR.

@ikappaki ikappaki closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant