Consider defn
name metadata for internal processing
#1188
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HI,
can you please consider patch to enable
defn
to process name metadata alongsidemap-attr?
. It partly addresses #1178 by allowingdefasync
to effectively pass meta keys such as:decorators
for consideration indefn
.While the actual code change is small, it introduces
:decorators
tests fordefn
anddefasync
, which were previously missing. These tests will help lay the groundwork for the next part: supporting the:decorators
meta key forfn
.I've also made a minor adjustement to the
defn
docstring to make it more obvious that the:decorations
key is not only defined overattr-map?
.Thanks