Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow up patch to fn :decorators support, minor doc and test update #1193

Merged

Conversation

ikappaki
Copy link
Contributor

@ikappaki ikappaki commented Dec 23, 2024

Hi,

can you please consider the follow up patch for anonymous fn decorators support (#1189).

  • Moved the note in python interop decorators doc at the top, as it contains important policy information.
  • Updated the fn docstring to document the form/name metadata precedence rules established in Adds support for :decorators in anon fns, defasync #1189, where name metadata takes precedence over form.
  • Added new test to verify precedence rule.
  • Corrected a test that was mistakenly using defn instead of fn.

I don't think this requires a changelog entry but I can add if necessary.

Thanks

src/basilisp/core.lpy Outdated Show resolved Hide resolved
@chrisrink10 chrisrink10 merged commit 5ef8525 into basilisp-lang:main Dec 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants