Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with ns being unavail after in-ns during eval (#718) #727

Conversation

ikappaki
Copy link
Contributor

Hi can you please review patch to fix the problem of ns becoming unavailable after executing in-ns in the context of the eval operation. It addresses #718.

(part of breaking the individual bugfixes from #723)

thanks

Copy link
Member

@chrisrink10 chrisrink10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just the minor changelog update.

CHANGELOG.md Outdated Show resolved Hide resolved
@ikappaki ikappaki force-pushed the issue/eval-ns-not-available-after-in-ns branch from ae7f5dc to 746167e Compare December 14, 2023 22:43
@chrisrink10 chrisrink10 merged commit 78d841a into basilisp-lang:main Dec 14, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants