Fix issue with readerwritelock
usage in basilisp (#722)
#731
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
could you please review patch to fix what it seems to be a potential issue with how readwrite locks are used in basilisp. It addresses #722.
This was discovered while testing of the upcoming nrepl-server described in #723. The nrepl-server tests which are using threads were failing due to trying to release an rlock which has been already released, and is fixed as described in #722 by using
with self._lock.gen_rlock()
instead of a single instance ofwith self._rlock()
. The error wasThanks