Upgrade to using PyTest 7 #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisrink10
force-pushed
the
fix/upgrade-to-pytest-7
branch
from
2c3f85c to
e95aceb
Compare
chrisrink10
commented
Dec 27, 2023
Comment on lines
+220
to
+224
| def _import_module(self) -> runtime.BasilispModule: | ||
| modname = _get_fully_qualified_module_name(self.path) | ||
| module = importlib.import_module(modname) | ||
| assert isinstance(module, runtime.BasilispModule) | ||
| return module |
There was a problem hiding this comment.
py.path.local used to have a function which did this before, so replacing it required some annoying re-implementation of that logic to figure out the module name and import it manually.
Comment on lines
+173
to
+174
| def __init__(self, **kwargs) -> None: | ||
| super().__init__(**kwargs) |
There was a problem hiding this comment.
chrisrink10
added a commit
that referenced
this pull request
Dec 28, 2023
Hi, could you please review patch to fix a break with the recent upgrade to pytest 7 in #738 in the circle CI coverage test. Fixes #740. The `_test` suffix was not preperly identified as a basilisp test suffix, and was failing the coverage tests for `stacktrace_test.lpy`, which was not following the same pattern as of the other test files. I've both fixed the testrunner to properly identifying these as before the upgrade, but also renamed the above to `test_stacktrace.lpy` for conformity with the current pattern. Thanks Co-authored-by: ikappaki <[email protected]> Co-authored-by: Chris Rink <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #660