Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support bencode for nrepl server #747

Merged
merged 3 commits into from
Dec 28, 2023
Merged

Support bencode for nrepl server #747

merged 3 commits into from
Dec 28, 2023

Conversation

chrisrink10
Copy link
Member

@chrisrink10 chrisrink10 commented Dec 28, 2023 •
edited
Loading

Part of #412

@chrisrink10 chrisrink10 marked this pull request as ready for review December 28, 2023 12:48
@chrisrink10 chrisrink10 mentioned this pull request Dec 28, 2023
Merged
@ikappaki
Copy link
Contributor

Do you want o to merge this to main, and I'll handle any potential issues when merging with #723?

@chrisrink10
Copy link
Member Author

Do you want o to merge this to main, and I'll handle any potential issues when merging with #723?

I think I do, yes. Does it look like it has the correct API?

@ikappaki
Copy link
Contributor

Do you want o to merge this to main, and I'll handle any potential issues when merging with #723?

I think I do, yes. Does it look like it has the correct API?

It looks good, thanks

@chrisrink10 chrisrink10 merged commit 8545148 into main Dec 28, 2023
10 checks passed
@chrisrink10 chrisrink10 deleted the feature/bencode branch December 28, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisrink10 @ikappaki