Explain why vendored repositories are considered out-of-date #24857
+182
−138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-ExternalDeps
fmeum
force-pushed
the
23243-explain-invalidation
branch
from
30ebaf3 to
cf07137
Compare
meteorcloudy
reviewed
Jan 8, 2025
fmeum
force-pushed
the
23243-explain-invalidation
branch
from
cf07137 to
9018577
Compare
meteorcloudy
reviewed
Jan 8, 2025
|
@bazel-io fork 8.1.0 |
meteorcloudy
approved these changes
Jan 8, 2025
|
Ping @Wyverald ! |
meteorcloudy
added
awaiting-PR-merge
meteorcloudy
requested changes
Jan 21, 2025
| }; | ||
| /** A sentinel "input" that's always out-of-date to signify parse failure. */ | ||
| public static final RepoRecordedInput PARSE_FAILURE = | ||
| new NeverUpToDateRepoRecordedInput("malformed marker file entry encountered"); |
There was a problem hiding this comment.
Got this error from internal check:
[ClassInitializationDeadlock] Possible class initialization deadlock: NeverUpToDateRepoRecordedInput is a subclass of the containing class RepoRecordedInput
new NeverUpToDateRepoRecordedInput("malformed marker file entry encountered");
^
(see http://go/bugpattern/ClassInitializationDeadlock)
| byte[] areRepositoryAndMarkerFileConsistent(RepositoryFunction handler, Environment env) | ||
| sealed interface RepoDirectoryState { | ||
| record UpToDate(byte[] markerDigest) implements RepoDirectoryState {} | ||
|
|
There was a problem hiding this comment.
[ArrayRecordComponent] Record components should not be arrays.
record UpToDate(byte[] markerDigest) implements RepoDirectoryState {}
^
(see http://go/bugpattern/ArrayRecordComponent)
There was a problem hiding this comment.
I ignored this one, but made the interface private to the file.
fmeum
force-pushed
the
23243-explain-invalidation
branch
from
ad54539 to
cfa0a28
Compare
fmeum
force-pushed
the
23243-explain-invalidation
branch
from
cfa0a28 to
32ae6f8
Compare
meteorcloudy
approved these changes
Jan 22, 2025
github-actions
bot
removed
the
awaiting-PR-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #23243