-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to fix grave/sarcophagus etc. not working #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added new prepatch `TryFindBestBetterStorageForPatch` 2. Moved `TryRemoveFromListerHaulables` from `TryFindBestBetterStoreCellFor` to the new prepatch 3. Rebuilt for realse so that changes take effect `TryFindBestBetterStoreCellForPatch` had been deciding which item should be removed from `listerHaulables`, which improves performance. But it had been checking `SlotGroup`s only. Patching `TryFindBestBetterStorageForPatch` and checking both Cell and NonCell achieves the same thing, and could solve the issue of grave/armor rack etc. not working. Tried several things. Nothing broke, and it solved said problem.
1. Added new prepatch `TryFindBestBetterStorageForPatch` 2. Moved `TryRemoveFromListerHaulables` from `TryFindBestBetterStoreCellFor` to the new prepatch 3. Rebuilt for release so that changes take effect `TryFindBestBetterStoreCellForPatch` had been deciding which item should be removed from `listerHaulables`, which improves performance. But it had been checking `SlotGroup`s only. Patching `TryFindBestBetterStorageForPatch` and checking both Cell and NonCell achieves the same thing, and could solve the issue of grave/armor rack etc. not working. Tried several things. Nothing broke, and it solved said problem.
…"flag", which is when `TryFindBestBetterStoreCellForPatch` is enabled.
So, first of, thanks for contributing again.
|
1. Added new prepatch `TryFindBestBetterStorageForPatch` 2. Rebuilt for realse so that changes take effect `TryFindBestBetterStoreCellForPatch` had been deciding which item should be removed from `listerHaulables`, which improves performance. But it had been checking `SlotGroup`s only. Patching `TryFindBestBetterStorageForPatch` to cancel the removal if the best storage is non-cell could solve the issue of grave/armor rack etc. not working. Tried several things. Nothing broke, and it solved said problem.
Don't format too much.
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TryFindBestBetterStorageForPatch
TryFindBestBetterStoreCellForPatch
had been deciding which item should be removed fromlisterHaulables
, which improves performance. But it had been checkingSlotGroup
s only.Patching
TryFindBestBetterStorageForPatch
and checking for NonCell could solve the issue of grave/armor rack etc. not working. #60Tried several things. Nothing broke, and it solved said problem.