Skip to content

Commit

Permalink
feat(export): append errs so we don't finish the export if they occur
Browse files Browse the repository at this point in the history
  • Loading branch information
fredrikvedvik committed Nov 16, 2023
1 parent 4c8298f commit 03e12ef
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions workflows/export/vx_export_vod.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ func VXExportToVOD(ctx workflow.Context, params VXExportChildWorkflowParams) (*V
err := f.Get(ctx, &result)
if err != nil {
logger.Error("Failed to get video result", "error", err)
service.errs = append(service.errs, err)
return
}
if lo.Contains(streamQualities, q) {
Expand Down Expand Up @@ -106,6 +107,9 @@ func VXExportToVOD(ctx workflow.Context, params VXExportChildWorkflowParams) (*V
return nil, err
}
}
for _, err = range service.errs {
return nil, err
}

return service.setMetadataAndPublishToVOD(
ctx,
Expand All @@ -122,6 +126,7 @@ type vxExportVodService struct {
streams []smil.Video
files []asset.IngestFileMeta
tasks []workflow.Future
errs []error
}

func prepareAudioFiles(ctx workflow.Context, mergeResult MergeExportDataResult, tempDir paths.Path) (map[string]paths.Path, error) {
Expand Down Expand Up @@ -237,6 +242,7 @@ func (v *vxExportVodService) handleFileWorkflowFuture(ctx workflow.Context, lang
err := f.Get(ctx, &result)
if err != nil {
logger.Error("Failed to get mux result", "error", err)
v.errs = append(v.errs, err)
return
}
code := bccmflows.LanguagesByISO[lang].ISO6392TwoLetter
Expand All @@ -259,6 +265,7 @@ func (v *vxExportVodService) handleStreamWorkflowFuture(ctx workflow.Context, q
err := f.Get(ctx, &result)
if err != nil {
logger.Error("Failed to get mux result", "error", err)
v.errs = append(v.errs, err)
return
}

Expand Down

0 comments on commit 03e12ef

Please sign in to comment.