Merge pull request #304 from bcc-code/chore/fix-non-determinism

Chore/fix non determinism

Makefile

@@ -0,0 +1,5 @@
+.PHONY: test
+
+test:
+	go vet ./...
+	go test -race ./...

workflows/export/prepare_files.go

@@ -75,10 +75,7 @@ func resolutionToString(r Resolution) resolutionString {
 func resolutionFromString(str resolutionString) Resolution {
 	var r Resolution
 
-	_, err := fmt.Sscanf(string(str), "%dx%d-%t", &r.Width, &r.Height, &r.File)
-	if err != nil {
-		fmt.Sprintf("Failed to parse resolution string %s, err: %s", str, err.Error())
-	}
+	_, _ = fmt.Sscanf(string(str), "%dx%d-%t", &r.Width, &r.Height, &r.File)
 
 	r.EnsureEven()
 	return r

workflows/misc/cleanup_production.go

@@ -30,6 +30,8 @@ type SortFilesByImportedDateParams struct {
 //
 // This workflow is intentionally not registered anywhere, as it is not meant to be used in normal day-to-day operations
 // without modification and testing.
+//
+//workflowcheck:ignore
 func SortFilesByImportedDate(
 	ctx workflow.Context,
 	params SortFilesByImportedDateParams,
@@ -43,7 +45,7 @@ func SortFilesByImportedDate(
 	cnt := 1
 	total := len(params.FileList)
 	failed := map[string]error{}
-	start := time.Now()
+	start := workflow.Now(ctx)
 
 	if params.BatchSize < 1 {
 		params.BatchSize = 1
@@ -52,7 +54,8 @@ func SortFilesByImportedDate(
 	filesChan := lo.SliceToChannel(params.BatchSize, params.FileList)
 
 	for {
-		items, _, _, ok := lo.Buffer(filesChan, params.BatchSize)
+		items, _, _, ok := lo.Buffer[string](filesChan, params.BatchSize)
+
 		if !ok {
 			break
 		}

workflows/scheduled/files_cleanup.go

@@ -28,7 +28,14 @@ func CleanupTemp(ctx workflow.Context) (*CleanupResult, error) {
 
 	deletedFiles := []string{}
 
-	for folder, olderThan := range foldersToCleanup {
+	folders, err := wfutils.GetMapKeysSafely(ctx, foldersToCleanup)
+	if err != nil {
+		return nil, err
+	}
+
+	for _, folder := range folders {
+		olderThan := foldersToCleanup[folder]
+
 		deletedFilesLoop := []string{}
 		err := wfutils.ExecuteWithLowPrioQueue(ctx, activities.Util.DeleteOldFiles, activities.CleanupInput{
 			Root:      paths.MustParse(folder),