Merge pull request #126 from bcc-code/fix/minus-inf

fix(audio-norm): Fix crash on -inf for silent audio files

activities/normalize.go

@@ -2,6 +2,8 @@ package activities
 
 import (
 	"context"
+	"math"
+
 	"github.com/bcc-code/bccm-flows/common"
 	"github.com/bcc-code/bccm-flows/paths"
 	"github.com/bcc-code/bccm-flows/services/ffmpeg"
@@ -44,6 +46,11 @@ func AnalyzeEBUR128Activity(ctx context.Context, input AnalyzeEBUR128Params) (*c
 		out.SuggestedAdjustment = -0.9 - analyzeResult.TruePeak
 	}
 
+	// Don't suggest adjustments below .5 dB, or for peaks below -69 dBTP
+	if math.Abs(out.SuggestedAdjustment) < 0.5 || out.TruePeak <= -69 {
+		out.SuggestedAdjustment = 0.0
+	}
+
 	return out, nil
 }
 

utils/execute_command.go

@@ -5,6 +5,7 @@ import (
 	"bytes"
 	"fmt"
 	"os/exec"
+	"strings"
 )
 
 // ExecuteCmd executes the cmd and returns through outputCallback line-by-line before returning the whole stdout at the end.
@@ -86,6 +87,12 @@ func ExecuteAnalysisCmd(cmd *exec.Cmd, outputCallback func(string)) (string, err
 
 	}
 
+	// replace -Inf with -99 if the audio was silent
+	result = strings.ReplaceAll(result, "\"-inf\"", "-99")
+
+	// replace inf with 0 target_offset if the audio was silent
+	result = strings.ReplaceAll(result, "\"inf\"", "0")
+
 	err = cmd.Wait()
 	if err != nil {
 		return "", fmt.Errorf("execution failed error: %s", err.Error())

workflows/normalize_audio.go

@@ -8,7 +8,7 @@ import (
 
 	"github.com/bcc-code/bccm-flows/activities"
 	"github.com/bcc-code/bccm-flows/common"
-	"github.com/bcc-code/bccm-flows/utils/workflows"
+	wfutils "github.com/bcc-code/bccm-flows/utils/workflows"
 	"go.temporal.io/sdk/temporal"
 	"go.temporal.io/sdk/workflow"
 )
@@ -69,21 +69,26 @@ func NormalizeAudioLevelWorkflow(
 	}
 
 	adjustResult := &common.AudioResult{}
-	err = wfutils.ExecuteWithQueue(ctx, activities.AdjustAudioLevelActivity, activities.AdjustAudioLevelParams{
-		Adjustment:  r128Result.SuggestedAdjustment,
-		InFilePath:  filePath,
-		OutFilePath: outputFolder,
-	}).Get(ctx, adjustResult)
-	if err != nil {
-		return nil, err
+
+	// Don't adjust if the suggested adjustment is less than 0.01 Db
+	if r128Result.SuggestedAdjustment <= 0.01 {
+		err = wfutils.ExecuteWithQueue(ctx, activities.AdjustAudioLevelActivity, activities.AdjustAudioLevelParams{
+			Adjustment:  r128Result.SuggestedAdjustment,
+			InFilePath:  filePath,
+			OutFilePath: outputFolder,
+		}).Get(ctx, adjustResult)
+		if err != nil {
+			return nil, err
+		}
+		filePath = adjustResult.OutputPath
 	}
 
-	out.FilePath = adjustResult.OutputPath.Local()
+	out.FilePath = filePath.Local()
 
 	if params.PerformOutputAnalysis {
 		r128Result := &common.AnalyzeEBUR128Result{}
 		err = wfutils.ExecuteWithQueue(ctx, activities.AnalyzeEBUR128Activity, activities.AnalyzeEBUR128Params{
-			FilePath:       adjustResult.OutputPath,
+			FilePath:       filePath,
 			TargetLoudness: params.TargetLUFS,
 		}).Get(ctx, r128Result)
 		if err != nil {