-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use current-color in svgs #262
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #262 +/- ##
==========================================
- Coverage 10.91% 10.70% -0.21%
==========================================
Files 95 97 +2
Lines 4306 4389 +83
Branches 179 181 +2
==========================================
Hits 470 470
- Misses 3746 3827 +81
- Partials 90 92 +2 ☔ View full report in Codecov by Sentry. |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-262.westeurope.3.azurestaticapps.net |
In the preview I could see that the following images have a change: Fill:
Color:
I was also surprised how many duplicates we actually have among those images... @sclausen is there a common procedure of extracting those images from Figma, or is there a reason why so many images are duplicated? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! There are a couple of icons with unnecessary fills though:
- download.svg
- icon.loading (animation).svg
Other than that, looks good!
Fills are fixed now 😎👍 Colors, which I lined out as change should be changed via CSS. |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-262.westeurope.3.azurestaticapps.net |
5aa1fe2
to
5746176
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-262.westeurope.3.azurestaticapps.net |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimonSimCity are you really referring to me? I have to admit that I have absolutely no memory participating in this project at all. |
@sclausen sorry for pulling you in here, I had a typo in the username 🙈 I meant to ping @sclausendk |
@sifferhans the two files you're referring to are not part of the changed files anymore - they're just part of individual commits 🤗 |
@SimonSimCity Ah, right! Then everything looks good to me 😁 |
Avoid the usage of css to define a color on an svg image, but rather in SVG use
currentColor
.