Creates endpoint for fetching student merges #21
Conversation
|
|
||
| import java.util.List; | ||
|
|
||
| @RequestMapping(URL.BASE_URL + "/pen-records/createDateInRange") |
There was a problem hiding this comment.
The path identifier createDateInRange could be moved to specific endpoint. Better to have in lowercase.
There was a problem hiding this comment.
Please modify this to:
@RequestMapping(URL.BASE_URL + "/student-merges")
| } | ||
|
|
||
| public List<StudentMerge> getMergedStudentsForDateRange(String createDateStart, String createDateEnd){ | ||
| return restUtils.getMergedStudentsForDateRange(UUID.randomUUID(), createDateStart, createDateEnd); |
There was a problem hiding this comment.
Do we need this randomID ?
There was a problem hiding this comment.
as far as I know, we do - it is only a transaction id that will be shared between the student api and assessments. basically grabbed this directly from how we are retrieving merges in sdc
There was a problem hiding this comment.
@eckermania - It's only useful if we log in on this side.
|
|
||
| @Slf4j | ||
| @RestController | ||
| public class PENRecordController implements PENRecordEndpoint { |
There was a problem hiding this comment.
Please rename this class & service to remove references to PEN. We're retrieving student merges.
| @@ -324,4 +327,26 @@ public List<School> getAllSchoolList(UUID correlationID) { | |||
| throw new EasAPIRuntimeException(NATS_TIMEOUT + correlationID + ex.getMessage()); | |||
| } | |||
| } | |||
|
|
|||
| @Retryable(retryFor = {Exception.class}, noRetryFor = {EasAPIRuntimeException.class}, backoff = @Backoff(multiplier = 2, delay = 2000)) | |||
There was a problem hiding this comment.
Please remove this line.
| /** | ||
| * The Student merge id. | ||
| */ | ||
| String studentMergeID; |
There was a problem hiding this comment.
This is also not nullable.
|
No description provided.