CMS-613: Filter empty notes out of /seasons payload (#81)

bcgov · Jan 14, 2025 · d787a3e · d787a3e
1 parent a2054d6
commit d787a3e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/backend/routes/api/seasons.js b/backend/routes/api/seasons.js
@@ -55,6 +55,13 @@ router.get(
           model: SeasonChangeLog,
           as: "changeLogs",
           attributes: ["id", "notes", "createdAt"],
+          // Filter out empty notes
+          where: {
+            notes: {
+              [Op.ne]: "",
+            },
+          },
+          required: false,
           order: [["createdAt", "DESC"]],
           include: [
             {

diff --git a/frontend/src/components/ChangeLogsList.jsx b/frontend/src/components/ChangeLogsList.jsx
@@ -16,7 +16,6 @@ export default function ChangeLogsList({ changeLogs = [] }) {
             </span>
           )}
           <span className="note-metadata">
-            {changeLog.notes ? "" : "Submitted "}
             {formatDate(changeLog.createdAt, "America/Vancouver")} by{" "}
             {changeLog.user.name}
           </span>