Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Panel on logout #3774

Merged
merged 5 commits into from
Jan 8, 2025
Merged

Conversation

meghna0593
Copy link
Collaborator

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring / Documentation
  • Version change

@meghna0593 meghna0593 linked an issue Jan 3, 2025 that may be closed by this pull request
LocalNewsTV
LocalNewsTV previously approved these changes Jan 8, 2025
Copy link
Collaborator

@LocalNewsTV LocalNewsTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Confirmed The Record panel is no longer accessible after logging out
  • Confirmed the Public map layer appears afterwards

Out of Scope for this ticket

  • Noticed Recordset layer markers are still visible on map after logout due to layers not being destroyed. Perhaps the native auth needs to be examined in the future, likely more things under the surface.
    • With the ability to work as an Offline user, it doesn't really matter.

Copy link

sonarqubecloud bot commented Jan 8, 2025

@meghna0593 meghna0593 merged commit 1283b8e into dev Jan 8, 2025
7 of 10 checks passed
@meghna0593 meghna0593 deleted the 3773-the-records-panel-visible-on-logout branch January 8, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile: On logout, the records panel is visible
3 participants