Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INV-3788] IAPP layer causes crash #3792

Merged
merged 4 commits into from
Jan 13, 2025
Merged

[INV-3788] IAPP layer causes crash #3792

merged 4 commits into from
Jan 13, 2025

Conversation

LocalNewsTV
Copy link
Collaborator

@LocalNewsTV LocalNewsTV commented Jan 13, 2025 •
edited
Loading

Overview

This PR includes the following proposed change(s):

  • Default Recordsets assign Filter Objects to Array [] instead of null
  • Fixed JSX error where key was invalid for IAPP Records in Map function
    • modified instances of Activity to RecordSetType.Activity for consistency across app
  • fix handle_PREP_FILTERS_FOR_VECTOR_ENDPOINT. RecordsetType is not an argument, and added optional chaining to obtain cacheMetadata
    • This corrects the error shown in the screenshot on the bug ticket
  • Closes Mobile: Creating an IAPP/IBC layer of records causes crash #3788

@LocalNewsTV LocalNewsTV marked this pull request as ready for review January 13, 2025 15:51
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@LocalNewsTV LocalNewsTV changed the title [INV-3788] IAPP layer causes crash [INV-3788][INV-3789] IAPP layer causes crash Jan 13, 2025
@LocalNewsTV LocalNewsTV changed the title [INV-3788][INV-3789] IAPP layer causes crash [INV-3788] IAPP layer causes crash Jan 13, 2025
@plasticviking plasticviking merged commit 11e00e4 into dev Jan 13, 2025
7 of 10 checks passed
@LocalNewsTV LocalNewsTV deleted the 3788-iapp-layer-causes-crash branch January 28, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plasticviking plasticviking Awaiting requested review from plasticviking

@meghna0593 meghna0593 Awaiting requested review from meghna0593

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mobile: Creating an IAPP/IBC layer of records causes crash
2 participants
@LocalNewsTV @plasticviking