Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCFS-1659: Incorrect fuel type list in Fuels for other use #1658

Merged

Conversation

areyeslo
Copy link
Collaborator

@areyeslo areyeslo commented Jan 10, 2025

This fix is focused on getting the correct list in fuel_type. The data might be changed in Dev and affected the list shown in the dropdown.

In addition, added clearing provisionOfTheAct when changing fuel_type.

image

Note: Renewable naphtha is not included because its fuel code is expired.

Story

Copy link

github-actions bot commented Jan 10, 2025

Frontend Test Results

  1 files  ±0  123 suites  ±0   45s ⏱️ ±0s
429 tests ±0  409 ✅ ±0  20 💤 ±0  0 ❌ ±0 
431 runs  ±0  411 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit e73dba9. ± Comparison against base commit e783917.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 10, 2025

Backend Test Results

503 tests  ±0   503 ✅ ±0   1m 44s ⏱️ -2s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit e73dba9. ± Comparison against base commit e783917.

♻️ This comment has been updated with latest results.

@areyeslo areyeslo changed the title LCFS-1207: Add Fuel code and CI columns to Fuels for other use grid LCFS-1659: Incorrect fuel type list in Fuels for other use Jan 10, 2025
@prv-proton prv-proton self-requested a review January 14, 2025 16:58
prv-proton

This comment was marked as outdated.

Copy link
Collaborator

@prv-proton prv-proton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revision head out of sync

@areyeslo areyeslo force-pushed the LCFS-1207-AddFuelCodeCIColumnsFuelsOtherUse_v2 branch from cc9d106 to dd0aaa2 Compare January 14, 2025 23:10
@areyeslo areyeslo requested a review from prv-proton January 15, 2025 00:12
Copy link
Collaborator

@prv-proton prv-proton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@areyeslo areyeslo force-pushed the LCFS-1207-AddFuelCodeCIColumnsFuelsOtherUse_v2 branch from 9b64428 to ef67759 Compare January 16, 2025 20:22
@areyeslo areyeslo merged commit 3ac4f0f into release-0.2.0 Jan 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants