25328 - Support Update and Save NoW Draft for Bootstrap Filing

[meawong]

Issue #: /bcgov/entity#25328

Description of changes:

• Add special case for NoW when getting a filing for a temp business
• Update unit tests
• Update requirements for NoW Schema changes (https://github.com/bcgov/business-schemas/releases/tag/2.18.33)

Post new NoW DRAFT:

• withdrawn filing id = 156853
• notice of withdrawal id = 156943
  

Get NoW DRAFT (156943):

Update and Save NoW DRAFT:
Params:

Body (updating certifiedBy field):

Response:

Get NoW DRAFT to confirm update was saved:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

[ArwenQin]

Thanks Megan! LGTM

[eason-pan-bc]

The implementation works.
Just thoughts, the method can be optimized a bit to reduce the amount of 'if statements' and use more sqlAlchemy features.

My idea is:

def get_temp_reg_filing(temp_reg_id: str, filing_id: str = None):
    """Return a filing by the temp id and filing id (if applicable)."""
    if not filing_id:
        return db.session.query(Filing).filter(Filing.temp_reg == temp_reg_id).one_or_none()
            
    return (
        db.session.query(Filing).filter(
            db.or_(
                db.and_(
                    Filing.id == filing_id,
                    Filing.temp_reg == temp_reg_id
                ),
                db.and_(  # special case for NoW
                    Filing.id == filing_id,
                    Filing._filing_type == 'noticeOfWithdrawal',
                    Filing.withdrawn_filing_id == db.session.query(Filing.id)
                        .filter(Filing.temp_reg == temp_reg_id)
                        .scalar_subquery()
                )
            )
        ).one_or_none())

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud