Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRIME-2798 Update deleting site and organization to soft-delete #2622

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from

Conversation

bergomi02
Copy link
Collaborator

No description provided.

@bergomi02 bergomi02 added DO NOT MERGE PR is in a broken state, do not merge Backend Updates to the backend of the application labels Oct 31, 2024
@bergomi02 bergomi02 requested a review from neophyte57 October 31, 2024 16:25
@bergomi02 bergomi02 self-assigned this Oct 31, 2024
@neophyte57
Copy link
Collaborator

Although I deleted a Site, if I try to use the Site ID of the deleted Site (as Admin), I get the "Site ID already used by another organization" error.

image

@bergomi02
Copy link
Collaborator Author

@bergomi02 bergomi02 temporarily deployed to Development November 28, 2024 09:45 — with GitHub Actions Inactive
@neophyte57
Member

Good catch! It is fixed.

@neophyte57
Copy link
Collaborator

@bergomi02 Was there a reason re: not filtering out soft-deleted Organizations in GetBaseOrganizationQuery?

@bergomi02
Copy link
Collaborator Author

@bergomi02 Was there a reason re: not filtering out soft-deleted Organizations in GetBaseOrganizationQuery?

No particular reason. Feel free to add the filtering into that base query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Updates to the backend of the application DO NOT MERGE PR is in a broken state, do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants