Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21893 Catch errors when updating NR data #1535

Merged

Conversation

EPortman
Copy link
Collaborator

Issue #: https://app.zenhub.com/workspaces/names-team-board-new-655554cbddd49510027dad2e/issues/gh/bcgov/entity/21893

Description of changes:

  • Added a try-catch block to the update function.
  • Removed unnecessary fetchAndLoadNr() calls as that method is already called in updateRequest()

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

@EPortman
Copy link
Collaborator Author

/gcbrun

@pwei1018 pwei1018 self-assigned this Aug 15, 2024
@pwei1018
Copy link
Collaborator

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://namex-dev--pr-1535-vm465li2.web.app

@EPortman EPortman merged commit 038580d into bcgov:main Aug 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants