-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SRS-361 Implement editing of Parcel Descriptions #243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Full transparency: I don't know much about parcel descriptions, so I'll leave the more detailed review to someone with that knowledge :D
Leaving one css-related comment though
frontend/src/app/features/details/parcelDescriptions/parcelDescriptions.css
Outdated
Show resolved
Hide resolved
frontend/src/app/features/details/parcelDescriptions/parcelDescriptions.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems fine to me
Description
This is the first of what I imagine will be two PRs to finalize Parcel Description edit mode. The next PR will implement Adding and Deleting.
This PR allows the user to change and save existing parcel description objects.
Fixes # SRS-361 Partially
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: