Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SRS-361 Implement editing of Parcel Descriptions #243

Merged
merged 11 commits into from
Jan 9, 2025

Conversation

bolny
Copy link
Contributor

@bolny bolny commented Dec 19, 2024

Description

This is the first of what I imagine will be two PRs to finalize Parcel Description edit mode. The next PR will implement Adding and Deleting.

This PR allows the user to change and save existing parcel description objects.

Fixes # SRS-361 Partially

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manual testing. I have edited and saved every field to the database.
  • All specs are passing.

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@bolny bolny self-assigned this Dec 19, 2024
@bolny bolny requested a review from a team as a code owner December 19, 2024 16:59
Copy link
Contributor

@anton-bcgov anton-bcgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full transparency: I don't know much about parcel descriptions, so I'll leave the more detailed review to someone with that knowledge :D

Leaving one css-related comment though

@bolny bolny requested review from a team and anton-bcgov December 23, 2024 16:27
@bolny bolny requested review from jaspalsingh-aot and a team January 7, 2025 19:05
@bolny bolny requested review from nupurdixit13, midhun-aot and a team January 7, 2025 22:03
Copy link
Contributor

@jaspalsingh-aot jaspalsingh-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me

@bolny bolny merged commit a916184 into dev Jan 9, 2025
15 checks passed
@bolny bolny deleted the feat/SRS-361-parceldescriptions-editmode branch January 9, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants