Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24492 - remove unnecessary 2nd custom cancel payment dialog. #285

Merged
merged 3 commits into from
Jan 7, 2025
Merged

24492 - remove unnecessary 2nd custom cancel payment dialog. #285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eeb210f
style: fixing style; comments from the UX.
hfekete Nov 13, 2024
7399c94
24492 - feat: remove unnecessary 2nd custom cancel payment dialog.
hfekete Jan 6, 2025
9b1fab7
Merge branch 'main' of github.com:hfekete/registries-search
hfekete Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions search-ui/src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
import { getFeatureFlag } from '@/utils'
import ContactInfo from './components/common/ContactInfo.vue'
import { DocumentAccessRequestStatus } from '@/enums/document-access-request'
import { PaymentCancelledError } from '@/resources/error-dialog-options/payment-canceled'

Check warning on line 88 in search-ui/src/App.vue

View workflow job for this annotation

GitHub Actions / linting (18) 

'PaymentCancelledError' is defined but never used

Check warning on line 88 in search-ui/src/App.vue

View workflow job for this annotation

GitHub Actions / build-check (18) 

'PaymentCancelledError' is defined but never used

const aboutText: string = 'Search UI v' + process.env.VUE_APP_VERSION
const appLoading = ref(false)
Expand Down Expand Up @@ -302,11 +302,6 @@
case ErrorCategories.DOCUMENT_ACCESS_PAYMENT_ERROR:
// handled inline and no error msg needed
break
case ErrorCategories.DOCUMENT_ACCESS_PAYMENT_CANCELLED:
errorInfo.value = {...PaymentCancelledError}
errorContactInfo.value = false
errorDisplay.value = true
break
default:
errorInfo.value = {...DefaultError}
errorContactInfo.value = true
Expand Down
8 changes: 0 additions & 8 deletions search-ui/src/composables/document-access-request-factory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { reactive } from 'vue'

import { DocumentType, ErrorCategories } from '@/enums'

Check warning on line 3 in search-ui/src/composables/document-access-request-factory.ts

View workflow job for this annotation

GitHub Actions / linting (18) 

'ErrorCategories' is defined but never used

Check warning on line 3 in search-ui/src/composables/document-access-request-factory.ts

View workflow job for this annotation

GitHub Actions / build-check (18) 

'ErrorCategories' is defined but never used
import {
AccessRequestsHistoryI,
CreateDocumentResponseI,
Expand Down Expand Up @@ -93,14 +93,6 @@
documentAccessRequest._needsPayment = false
}
documentAccessRequest._saving = false
// show payment canceled dialog
documentAccessRequest._error = {
category: ErrorCategories.DOCUMENT_ACCESS_PAYMENT_CANCELLED,
detail: 'not used',
message: 'not used',
statusCode: null,
type: null
}
return
}

Expand Down
1 change: 0 additions & 1 deletion search-ui/src/enums/errorCategories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ export enum ErrorCategories {
DOCUMENT_ACCESS_REQUEST_CREATE = 'document-access-request-create',
DOCUMENT_ACCESS_REQUEST_HISTORY = 'document-access-request-history',
DOCUMENT_ACCESS_PAYMENT_ERROR = 'document-access-request-payment-error',
DOCUMENT_ACCESS_PAYMENT_CANCELLED = 'document-access-request-payment-cancelled',
ENTITY_BASIC = 'entity-basic',
ENTITY_FILINGS = 'entity-filings',
FEE_INFO = 'fee-info',
Expand Down