Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v7.1.1 #145

Closed
wants to merge 12 commits into from
Closed

Release/v7.1.1 #145

wants to merge 12 commits into from

Conversation

sshugsc
Copy link
Contributor

@sshugsc sshugsc commented Apr 9, 2024

New Features

  • [KBDEV-1194] - get recent studies from clinicaltrialsgov

@sshugsc sshugsc self-assigned this Apr 9, 2024

This comment has been minimized.

@mathieulemieux
Copy link
Member

@elewis2 ,
About 1 month ago in v7.0.0 we had a breaking change for this loader (PR#135) because we moved it from a File one to an API one. Now it moved again from API to stand alone, so the command line need to change again, making again the change "breaking".

I guess the options are:

  • we ignore it's kinda breaking and make a minor release;
  • we go for another major release;
  • we modify the CLI parser so we can call this loader with the api subparser.

@elewis2
Copy link
Collaborator

elewis2 commented Apr 10, 2024

Can you elaborate on option three in this list @mathieulemieux ?

@mathieulemieux
Copy link
Member

ok, so @sshu, will go with v8.0.0.

@sshugsc sshugsc changed the title Release/v7.1.1 Release/v8.0.0 Apr 10, 2024
@sshugsc sshugsc changed the title Release/v8.0.0 Release/v7.1.1 Apr 10, 2024
@sshugsc sshugsc closed this Apr 10, 2024
@sshugsc sshugsc deleted the release/v7.1.1 branch April 10, 2024 22:17
Copy link

Unit Test Results

0 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8eedd2c. ± Comparison against base commit fe8e1fd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants