Feature/kbdev 1225 update dgidb loader #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actual DB got 27402 TargetOf edges, all from DGIdb, while the loader is only creating a small fraction of those (3892 on a new DB, 4081 on production-syns-dev). Seems to be related to the ~20k logged errors for spec. Former Chembl drug ids seems to have been replaced by rxNav (rxcui) ids. Also, current loader is not deleting/updating deprecated links. |
mathieulemieux
requested changes
Aug 7, 2024
There was a problem hiding this comment.
See ticket https://www.bcgsc.ca/jira/browse/KBDEV-1225
If we decide to still go through:
- loader will need to support drug ontologies other than ChEMBL
- loader will need to support deletions/updates
|
Decide to not develop this loader for now. PR closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KBDEV-1125