dev/review notes #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
livingrockrises
commented
Sep 11, 2024
•
livingrockrises
commented
- Should make list of all positive and negative test cases we are planning to add.
- Add accounting test cases
- Run this on fork of some mainnet using real feeds
- Run swapping function on fork of some mainnet
livingrockrises
commented
Sep 11, 2024
| @@ -44,15 +44,22 @@ contract BiconomyTokenPaymaster is | |||
| using SignatureCheckerLib for address; | |||
|
|
|||
| // State variables | |||
|
|
|||
| // Review: where will the be used since we have pre charge and refund model? | |||
There was a problem hiding this comment.
we can just discuss here on each points by starting a comment like this
@ShivaanshK
There was a problem hiding this comment.
I agree. FeeCollector is unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.