features/paymaster-impots #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
livingrockrises
requested review from
ankurdubey521,
Aboudjem and
AmanRaj1608
ankurdubey521
approved these changes
Oct 11, 2023
AmanRaj1608
reviewed
Oct 12, 2023
package.json
Outdated
| @@ -80,6 +80,7 @@ | |||
| "solidity-coverage": "^0.8.2" | |||
| }, | |||
| "dependencies": { | |||
| "@biconomy-devx/paymasters": "^1.0.0", | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
removed this dependency now to publish a package
AmanRaj1608
approved these changes
Oct 12, 2023
|
please rename the branche to |
Aboudjem
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SMA-49 and SMA-51
using paymaster package imports to write test case which can optionally send transaction using verifying paymaster.
Related Issue: # (issue number)
Change Type
Checklist
Additional Information
Branch Naming