Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: signer typescript issues #158

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

VGabriel45
Copy link
Collaborator

@VGabriel45 VGabriel45 commented Dec 27, 2024

This PR fixes the typescript issues related to other unknown signer types.
This PR specifically fixes the issues mentioned in this ticket: https://linear.app/biconomy-20/issue/BIC-104/integration-issue-privy-embedded-wallet-with-biconomy-nexus-sdk


PR-Codex overview

This PR focuses on refining the handling of EthersWallet and introducing a new type ValidSigner to enhance type safety. It simplifies the code by removing unnecessary type assertions and improves the toSigner function to accommodate various signer types.

Detailed summary

  • Removed EthersWallet type and replaced it with ValidSigner.
  • Updated toSigner function to use ValidSigner for better type handling.
  • Added tests for ethers.JsonRpcSigner support.
  • Cleaned up imports and type definitions across several files.
  • Simplified wallet creation in tests by removing unnecessary type assertions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@VGabriel45 VGabriel45 requested a review from joepegler December 27, 2024 11:19
Copy link

github-actions bot commented Dec 27, 2024

size-limit report 📦

Path Size
core (esm) 16.3 KB (-0.14% 🔽)
core (cjs) 22.83 KB (+0.26% 🔺)
bundler (tree-shaking) 518 B (0%)
paymaster (tree-shaking) 543 B (0%)

@VGabriel45 VGabriel45 marked this pull request as draft December 27, 2024 11:29
@VGabriel45 VGabriel45 marked this pull request as ready for review December 27, 2024 15:11
@VGabriel45 VGabriel45 requested review from TurboFolkBlackMetal and removed request for joepegler December 27, 2024 15:12
@joepegler joepegler force-pushed the develop branch 2 times, most recently from a93c10a to 8f76a15 Compare January 8, 2025 09:51
@VGabriel45 VGabriel45 requested a review from joepegler January 15, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant