Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the typescript issues related to other unknown signer types.
This PR specifically fixes the issues mentioned in this ticket: https://linear.app/biconomy-20/issue/BIC-104/integration-issue-privy-embedded-wallet-with-biconomy-nexus-sdk
PR-Codex overview
This PR focuses on refining the handling of
EthersWallet
and introducing a new typeValidSigner
to enhance type safety. It simplifies the code by removing unnecessary type assertions and improves thetoSigner
function to accommodate various signer types.Detailed summary
EthersWallet
type and replaced it withValidSigner
.toSigner
function to useValidSigner
for better type handling.ethers.JsonRpcSigner
support.