Feat/refactor, fix build, lint issues and tests. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved SMA-526
…o feat/SMA-540-check-paymaster-userop
Paymaster check and setup logic on SDK (SPONSORED | ERC20).
Fix UserOpResponse wait confirmations
* Added Signer Abstraction
fix:circular_dependency
Chore(SMA-547): Chore: Move common code into common package
Co-authored-by: GabiDev <[email protected]>
* Update README.md
* Add paymasterAndData validation in e2e tests * Use config values instead of hardcoded in tests --------- Co-authored-by: GabiDev <[email protected]>
* Resolved SMA-549 lint:fix log * continued * continued * continued * Remove e2e test from unit test commit lockfile * rpc test * fix tests
* Refactor paymasterServiceData validation logic for ERC20 mode * Add assertions and test case for ERC20 Paymaster user op * Changed isNullOrUndefined function param to any type * Update createSmartWalletClient to createSmartAccountClient * Added ts-doc for setPaymasterUserOp * Export FeeQuotesOrDataResponse from @account and update import path in test * Refactor setPaymasterUserOp --> getPaymasterUserOp --------- Co-authored-by: GabiDev <[email protected]>
* Fix for etherv6 signer compatibility * Refactor name --------- Co-authored-by: GabiDev <[email protected]>
* Resolved SMA-559 * Fix await * Fix tests * Update docs * remove unused import * Fix broken tests * Fix rpc url * buildTokenPaymasterUserOp * lint:fix * Fix spender * Abstract tokenlist away * fix test * fix await * lint:fix * Make getPaymasterUserOp public * remove log
…g redundant tests & skiping temporary tests
* chore: testing framework
* chore: add test support for smart sessions
* feat: eip 712 (draft) * feat: added signTypedData for Nexus (draft) * feat: signTypedData + tests on baseSepolia testnet * refactor: fix build errors * feat: updated to latest nexus contracts * fix tests --------- Co-authored-by: VGabriel45 <[email protected]> Co-authored-by: livingrockrises <[email protected]>
chore: refactor (#574)
…add missing features after viem refactor + fix issues & conflicts +++ (#576) * fixed ownable validator implementation and tests * refactor: refactor OwnableValidator instance class * feat: added signature override to sendTransaction * refactor: switch to local network (draft) * fix: sort owners for module install data and change commit hash for deployed accounts * refactor: remove signature override for now * fix: fallback installation & get installed modules * feat: fix ownable validator initialization and add test * fixed conflicts + added missing functionality + tests * feat: ownable validator multi signature test + fixes * feat: add signatureOverride param * refactor: remove console.logs * feat: added tests for ownable executor & cleanup * refactor: cleanup * refactor: removed useless decorator * fix: fix build errors --------- Co-authored-by: VGabriel45 <[email protected]>
…-sdk into feat/missing_pieces
size-limit report 📦
|
Coverage Report
File CoverageNo changed files found. |
VGabriel45
changed the title
joepegler
approved these changes
Sep 24, 2024
| test.skip("should create a nexusAccount from an ethers signer", async () => { | ||
| const ethersProvider = new JsonRpcProvider(chain.rpcUrls.default.http[0]) | ||
| const ethersSigner = new Wallet(pKey, ethersProvider) | ||
| // test.skip("should create a nexusAccount from an ethers signer", async () => { |
| factoryAddress = contracts.k1ValidatorFactory.address, | ||
| k1ValidatorAddress = contracts.k1Validator.address, | ||
| bundlerTransport, | ||
| paymaster, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on refactoring the codebase to replace instances of
holderwithsigner, improving type definitions, and enhancing the functionality of modules related to account management and validation. Additionally, it updates tests to reflect these changes.Detailed summary
CHANGELOG.mdfor version0.0.0.@rhinestone/module-sdkdependency inpackage.json.holderwithsignerin various files, including:src/sdk/account/utils/index.tssrc/sdk/clients/createNexusClient.tssrc/sdk/modules/base/BaseModule.tssignerinstead ofholder.signerimplementation.src/sdk/account/toNexusAccount.tsto usesignerin parameters.