[PN-68] add unit test for robot command goal complete #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abaker-bdai
requested review from
METEORITENMAX,
jbarry-bdai,
amessing-bdai,
mpickett-bdai,
bhung-bdai and
ksharma-bdai
as code owners
abaker-bdai
deleted the
abaker/PN-68-add-unit-test-for-robot_command_goal_complete
branch
|
@jiuguangw @baxelrod-bdai @amessing-bdai don't really know who to task this of but does the CI for this repo actually run the tests? i was just checking and i see it building but i'm not sure i see the test running... |
So I was the one who set up running colcon test for the bdai repo CI. Spot_ros2 CI does not run tests (because at the time there were no tests...) https://github.com/bdaiinstitute/spot_ros2/actions/runs/6643074260/workflow?pr=167 |
marlow-fawn
pushed a commit
to marlow-fawn/spot_ros2
that referenced
this pull request
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of 3 PRs to refactor
_robot_command_goal_completeso that is more readable and easier to maintain.In this PR, we are adding a unit test to capture and verify the current logic of the function before refactoring it in order to prevent introducing any regressions.
Writing the unit test also caught a few bugs and missing checks for some statuses which will be address in the final PR.
2nd PR: #167