Add dark/light mode switch buttons in Options menu #1950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Adoliin, thanks for the code! Would be awesome to get this in at some point. FWIW, I've also tested this together with fava-dashboards. It needs some changes to the library like Evernight/fava-dashboards@9872223 but works well after that. Didn't get a chance to try #1883 before. Personally, I think a tidy single icon (not a toggle) next to the filters could be well-fitting as well but switch in the options works nicely too (imo). Not qualified to comment on CSS changes though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve these 2 issues:
#1883
#1874
Descriptiopn
The website style can now be manually set by going to
Optionsin the side bar menu and selecting one of the 3 optionsSystemLightDarkScreenshot