Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request more info feature as an admin #284

Closed
wants to merge 11 commits into from

Conversation

perryzjc
Copy link
Contributor

Pivotal Tracker Link

This is basically like 3 stories in one branch, so... yeah. But here is the original story:

Other pivotal tracker links:
Pivotal Tracker Link2
Pivotal Tracker Link3

What this PR does:

Summary of relevant changes:

  1. Added a request more info button for admin
  2. Added rspec test and cucumber test for this new feature
  3. Added a request more info email template
  4. Added a new field for liquid engine: request_reason
  5. Fix relevant naming for reason

This pull request fixes|implements (pick one...) implements.

Include screenshots, videos, etc.

image image image

Who authored this PR?

  1. Perry (Jingchao) Zhong
  2. Razvan Turcu (Raz)

How should this PR be tested?

  • What do the specs/features test?
    • Test email content correctness
    • Test user workflow of requesting more info as an admin
  • Are there edge cases to watch out for?
    No.

Are there any complications to deploying this?

Yes. We changed the request info email template, and it's a seed data. To see the change, we need to do rails db:seed

Checklist:

  • Tag someone for code review (either a coach / team member)
  • I have renamed the branch to match PivotTracker's suggested one (necessary for BlueJay) (e.g. michael/12345-add-new-feature Any branch name will do as long as the story ID is there. You can use git checkout -b [new-branch-name])

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.20%. Comparing base (d35ca2c) to head (21718e5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
+ Coverage   81.95%   83.20%   +1.24%     
==========================================
  Files          20       20              
  Lines         654      655       +1     
==========================================
+ Hits          536      545       +9     
+ Misses        118      110       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@perryzjc perryzjc changed the title 187044299/feature/request reason Add request more info feature as an admin Feb 27, 2024
@perryzjc perryzjc closed this Feb 27, 2024
@perryzjc
Copy link
Contributor Author

Misclicked to make the PR to a wrong repo. Correct one should be this: cs169#32

@ArushC ArushC deleted the 187044299/feature/request_reason branch February 27, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants