Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validated DSEP Specification with Core v 1.1.0 #175

Open
wants to merge 13 commits into
base: draft
Choose a base branch
from

Conversation

emmayank
Copy link
Collaborator

Description

Validated the dsep.yaml file with the core-spec v1.1.0 version. Also, validated the examples JSON files given in the example directory and in the implementation guide against core-spec v1.1.0.

Task Completed

  1. Validated dsep.yaml with core-spec v1.1.0 & Made Fixes
  2. Validated the examples in the dsep domain repository against core-spec v1.1.0 ( for All Categories i.e courses, scholarship, work opportunities etc) and made fixes.
  3. Validated the examples used in the implementation guide against core-spec v1.1.0 and made fixes.

Analysis of DSEP Examples against core V1.1.0

1. Course

  1. on_cancel - item.quantity, billing, fulfillment.customer.person.cred- schema issue
  2. Rating - schema issue
  3. on_select - item.quantity schema issue
  4. Support - schema issue [Fix not required]
  5. on_update - item.quantity schema issue

2. Expert Connect

  1. Everywhere version should be V1.1.0 in the context.version
  2. Fulfillment scheme issue
  3. Complete on_search schema need fix
  4. Select - ProviderID, fulfillment id is not selected
  5. OnSelect - Schema issue
  6. Init/confirm - billing - schema issue
  7. on_init - Schema issue
  8. On_confirm - Schema issue
  9. on_cancel - Schema issue
  10. Rating - Schema Issue
  11. On_status - Schema issue
  12. Support & on_support Schema Issue [Fix not required]
  13. on_update - Schema issue

3. Financial Support (0.7.0)

  1. on_init : message.order.payments[0].params.bank_account_name is not available in core-v1.1.0 [Fix not required]
  2. on_init: message.order.items.xinput - schema has some attributes which are not available in core-v1.1.0 [Fix not required]
  3. Confirm : message.order.fulfillments[0].customer.id is not available in core-v1.1.0 [Fix not required]
  4. on_confirm - message.order.docs is not present in core-v1.1.0 [Fix not required].
  5. Rating - schema is wrong
  6. Support & on_support - has some new attributes in the schema [Fix not required].

4. Student Connect

  1. Search-by-location - Incorrect Schema
  2. On_confirm - message.order.docs is not present in core-v1.1.0 [Fix not required].

5. Work Opportunity

  1. Search - Intent - item should be an object
  2. On_search - empty payment object
  3. Rating - Schema issue
  4. Support & on_support - has some new attributes in the schema [Fix not required].

Note

  1. [Fix not required]. - It means some schema which were modified in dsep domain specs during ONEST go-live, but they are not present in core-v1.1.0. A draft release note is already created for core-v1.2.0 - https://github.com/beckn/protocol-specifications/releases/tag/untagged-e6435da5f188a45da8ff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant