Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core v1.1.1 #439

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Core v1.1.1 #439

merged 2 commits into from
Jan 8, 2025

Conversation

rajaneeshk90
Copy link
Collaborator

Description:

This PR addresses this issue created in the protocol-specification repository: #433

Changes made:

  • Changed openAPI version from 3.0 to 3.1 in the Beckn core protocol specification
  • Minor change: Changed Beckn core specification version from 1.0.0 to 1.1.1 in example documentation

How to verify that the change does not break the existing specification:

  • Open an openAPI3.1 validator: https://editor-next.swagger.io/
  • Copy the content from the api/transaction/build/transaction.yaml file and paste it into the swagger editor(link above)
  • the editor will give errors on the page if there are invalid syntax in the openAPI document.

rajaneeshk90 and others added 2 commits July 2, 2024 21:36
@rajaneeshk90
Releasing the version 1.1.1 of Beckn core specification
d98a9b6 
	- Changing openAPI version from 3.0 to 3.1 in core protocol specification
	- Minor change: change version from 1.0.0 to 1.1.1 in example documentation
@rajaneeshk90
Merge pull request #434 from rajaneeshk90/core-v1.1.1
82d8a89 
Releasing the version 1.1.1 of Beckn core protocol specification
@rajaneeshk90 rajaneeshk90 mentioned this pull request Aug 14, 2024
Open
ravi-prakash-v
ravi-prakash-v approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@ravi-prakash-v ravi-prakash-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@ravi-prakash-v ravi-prakash-v requested a review from sjthnrk January 8, 2025 09:40
venkatramanm
venkatramanm approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@venkatramanm venkatramanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok

sjthnrk
sjthnrk approved these changes Jan 8, 2025
View reviewed changes
Copy link

@sjthnrk sjthnrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@ravi-prakash-v ravi-prakash-v merged commit f4da105 into master Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjthnrk sjthnrk sjthnrk approved these changes

@ravi-prakash-v ravi-prakash-v ravi-prakash-v approved these changes

@pramodkvarma pramodkvarma pramodkvarma approved these changes

@venkatramanm venkatramanm venkatramanm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rajaneeshk90 @venkatramanm @pramodkvarma @ravi-prakash-v @sjthnrk