Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: Update Status API #69

Merged
merged 17 commits into from
Apr 9, 2024
Merged

Added: Update Status API #69

merged 17 commits into from
Apr 9, 2024

Conversation

shreyvishal
Copy link
Collaborator

Description

This PR will add update status API and get status API

Features covered

NO-Ticket Availbale Yest

Changes made

  • Added a new controller for update status and get status

Screenshots/recordings

NA

Testing

NA

Self checks

  • Code follows coding style guidelines.
  • All tests pass successfully.
  • No new linting errors or warnings.
  • Documentation is updated, if necessary.
  • Dependencies are updated, if required.
  • There are no merge conflicts.

Reviewer Suggestions

NA

@shreyvishal shreyvishal requested a review from mayurvir April 8, 2024 09:49
@shreyvishal shreyvishal force-pushed the feat/update_status branch 3 times, most recently from 751d3da to 1fd4a1f Compare April 9, 2024 01:41
import logger from '../utils/logger.js'
import {db} from '../server.js'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have reverted this

@@ -149,6 +149,38 @@ class DBService {

return sessions;
}
async set_data(key, data) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are these functions being used for?

Copy link
Collaborator Author

@shreyvishal shreyvishal Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed these function for now but thought, it could be used as a getter and setter later on

@mayurvir mayurvir merged commit 12f13fa into main Apr 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants