Merge pull request #137 from bedatadriven/fix-translation-settings-test

Update tests for removal of translation setting properties
bedatadriven · Nov 8, 2024 · d6a6881 · d6a6881
2 parents 3b85289 + 4d66d28
commit d6a6881
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/tests/testthat/_activityInfoSnaps/databases-databaseTree.RDS b/tests/testthat/_activityInfoSnaps/databases-databaseTree.RDS
diff --git a/tests/testthat/_snaps/databases.md b/tests/testthat/_snaps/databases.md
@@ -319,7 +319,7 @@
 # roleAssignment() works
 
     Code
-      roleAssignment(roleId = "rp", roleParameter = list(partner = "test:test"),
+      roleAssignment(roleId = "rp", roleParameters = list(partner = "test:test"),
       roleResources = list("resource1", "resource2", "resource3"))
     Output
       $id

diff --git a/tests/testthat/test-databases.R b/tests/testthat/test-databases.R
@@ -35,7 +35,6 @@ testthat::test_that("getDatabaseSchema() and getDatabaseTree() return same value
 testthat::test_that("getDatabaseTree() works", {
   tree <- getDatabaseTree(databaseId = database$databaseId)
   testthat::expect_s3_class(tree, "databaseTree")
-  testthat::expect_named(tree, c("databaseId", "userId", "version", "label", "description", "ownerRef", "billingAccountId", "language", "originalLanguage", "continuousTranslation", "translationFromDbMemory", "thirdPartyTranslation", "languages", "role", "suspended", "storage", "publishedTemplate", "resources", "grants", "locks", "roles", "securityCategories"))
   testthat::expect_identical(tree$databaseId, database$databaseId)
   expectActivityInfoSnapshotCompare(tree, snapshotName = "databases-databaseTree", allowed_new_fields = TRUE)
 })
@@ -558,7 +557,7 @@ testthat::test_that("Missing role resources and parameters are reported", {
 testthat::test_that("roleAssignment() works", {
   testthat::expect_snapshot(roleAssignment(
     roleId = "rp",
-    roleParameter = list(partner = "test:test"),
+    roleParameters = list(partner = "test:test"),
     roleResources = list("resource1", "resource2", "resource3")
   ))
 })