Brewtils Plugin requires #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBurchLog
reviewed
Aug 20, 2024
brewtils/plugin.py
Outdated
| def get_system_dependency(self, require, timeout=300): | ||
| wait_time = 0.1 | ||
| while timeout > 0: | ||
| system = self._ez_client.find_unique_system(name=require) |
There was a problem hiding this comment.
I have to check, but if we have access to the Garden name of the local plugin, we should pass that forward as a filter criteria.
There was a problem hiding this comment.
local=True seems to be ok
TheBurchLog
reviewed
Aug 20, 2024
brewtils/plugin.py
Outdated
| and any("RUNNING" == instance.status for instance in system.instances) | ||
| ): | ||
| return system | ||
| self._wait() |
There was a problem hiding this comment.
you don't give it the wait time
There was a problem hiding this comment.
Now using the wait time
…tils into plugin-requires
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.