Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lastgenre: New config option keep_existing #4982

Open
wants to merge 41 commits into
base: master
Choose a base branch
from
+501 −137
Open

Lastgenre: New config option keep_existing #4982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
8d923fa
Quickfix lastgenre always overwriting multi-genre
JOJ0 May 3, 2023
e3f737c
Fix track-level genre handling in lastgenre plugin
JOJ0 Aug 30, 2023
1d5eaeb
Streamline lastgenre singleton log with album log
JOJ0 May 21, 2023
26d1455
Handle dups of existing genres in lastgenre plugin
JOJ0 Jun 17, 2023
a437506
Prevent album genre inherit only when source:track
JOJ0 Nov 3, 2023
9b7e041
Fix lastgenre source:track handling during imports
JOJ0 Nov 4, 2023
449c274
Another round of lastgenre logging nitpicks
JOJ0 Nov 4, 2023
17567f1
Refactor lastgenre keep_allowed to list comprehension
JOJ0 Nov 16, 2023
9c09074
Use separator as configured instead of hardcoding
JOJ0 Nov 16, 2023
3b339c8
Use provided deduplicate function for keep_allowed
JOJ0 Nov 16, 2023
87ab87f
Add lastgenre keep_allowed options (-k/-K)
JOJ0 Sep 14, 2024
0704034
Docs for lastgenre keep_allowed/force
JOJ0 Sep 15, 2024
de7cfd7
Implement --force and --keep-allowed behaviours
JOJ0 Sep 17, 2024
3307e41
Refactor keep/new genres combination
JOJ0 Oct 31, 2024
f1247e9
Quickfix constant msgpack poetry issue
JOJ0 Nov 1, 2024
197a26f
lastgenre: Add comments over groups of methods
JOJ0 Nov 1, 2024
a069e50
Experiment with test_lastgenre
JOJ0 Dec 15, 2024
f4ffc9f
Fix default for _dedup_genre whitelist arg
JOJ0 Jan 2, 2025
0dd4ef4
_combine_and_label return None not empty str
JOJ0 Jan 2, 2025
5892870
Fallback to next stage when fetch_ returns None
JOJ0 Jan 2, 2025
b81f4ca
Refactor _get_genre test to parametrized pytest
JOJ0 Jan 1, 2025
7a60c91
Add lastgenre testcase with unicode \0 separator
JOJ0 Jan 2, 2025
b0fac0d
Temporary lastgenre debug messages for @arsaboo
JOJ0 Jan 3, 2025
b7f8716
Clarify lastgenre _is_allowed docstring
JOJ0 Jan 3, 2025
f86d483
Rewrite docs for keep_allowed/existing change
JOJ0 Jan 3, 2025
009e965
Rename lastgenre option, refactor, new default
JOJ0 Jan 3, 2025
c1253f4
lastgenre test _get_genre for renamed keep_existing
JOJ0 Jan 3, 2025
9cb92c8
Fix lastgenre "count" issue
JOJ0 Jan 4, 2025
df5f54f
Handle genres as list, count/format/str helper
JOJ0 Jan 5, 2025
cb013d1
Refactor lastgenre mocked fetchers return list
JOJ0 Jan 5, 2025
2c7f54f
Fix/add lastgenre fallback tests
JOJ0 Jan 5, 2025
5e23cf3
lastgenre _is_allowed detailed logging
JOJ0 Jan 5, 2025
e582064
Refactor again _combine_and_label_genres
JOJ0 Jan 6, 2025
37789db
Fix lastgenre limit to count test
JOJ0 Jan 6, 2025
f230be7
Fix _dedup_genre, ensure lower case
JOJ0 Jan 7, 2025
99898e8
_resolve_genre as list tests, add test_to_delimited_string
JOJ0 Jan 6, 2025
f97b9ce
Final lastgenre plugin linting
JOJ0 Jan 8, 2025
d8ce25a
Final lastgenre docs changes
JOJ0 Jan 8, 2025
2025a56
Add a temporary log around whitelist setup
JOJ0 Jan 8, 2025
d8fea77
Temporary debug messages in _sort_by_depth
JOJ0 Jan 9, 2025
8730abf
Fix previous temp log messages
JOJ0 Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading