Merge core_foundation module into eventloop #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the only module that still uses Core Foundation. Many of core_foundation's definitions were event-loop-specific already, and one (CFRunLoopRef) was duplicated across the two modules.
freakboy3742
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #88 the
rubicon.objc.core_foundationmodule doesn't contain many definitions anymore. Some of them were unused, and the rest were only used by therubicon.objc.eventloopmodule. The module isn't documented and doesn't contain much that would be interesting for external users, and a quick GitHub search only brings up copies of Rubicon and outdated BeeWare examples, so I think it's safe to remove this module and move the remaining contents into.eventloop.