Remove some over-enthusiastic memory retention.

beeware · Apr 5, 2024 · c714175 · c714175
1 parent dad68bb
commit c714175
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 3 deletions.
diff --git a/cocoa/src/toga_cocoa/widgets/detailedlist.py b/cocoa/src/toga_cocoa/widgets/detailedlist.py
@@ -83,7 +83,6 @@ def tableView_objectValueForTableColumn_row_(self, table, column, row: int):
             data = value._impl
         except AttributeError:
             data = TogaData.alloc().init()
-            data.retain()
             value._impl = data
 
         try:

diff --git a/cocoa/src/toga_cocoa/widgets/table.py b/cocoa/src/toga_cocoa/widgets/table.py
@@ -73,7 +73,6 @@ def tableView_viewForTableColumn_row_(self, table, column, row: int):
 
             # Prevent tcv from being deallocated prematurely when no Python references
             # are left
-            tcv.retain()
             tcv.autorelease()
 
         tcv.setText(str(value))

diff --git a/cocoa/src/toga_cocoa/widgets/tree.py b/cocoa/src/toga_cocoa/widgets/tree.py
@@ -101,7 +101,6 @@ def outlineView_viewForTableColumn_item_(self, tree, column, item):
 
             # Prevent tcv from being deallocated prematurely when no Python references
             # are left
-            tcv.retain()
             tcv.autorelease()
 
         tcv.setText(str(value))