Skip to content

Commit

Permalink
[MINOR][INFRA] Comments in GitHub scripts should start with #
Browse files Browse the repository at this point in the history
### What changes were proposed in this pull request?
The pr aims to fix a typo in github action script, `comments` in GitHub scripts should start with `#`.

### Why are the changes needed?
In the GitHub runtime logs, we often observe runtime prompts similar to the one below:
https://github.com/panbingkun/spark/actions/runs/7167111730/job/19513821177
https://github.com/panbingkun/spark/actions/runs/7167111730/job/19513823103
<img width="690" alt="image" src="https://github.com/apache/spark/assets/15246973/26d39f6c-e6e3-4887-9344-a8fa251a255e">
Although it does not affect the overall task execution, I think it is necessary to correct it.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Manually test.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes apache#44473 from panbingkun/address_github.

Authored-by: panbingkun <[email protected]>
Signed-off-by: Ruifeng Zheng <[email protected]>
  • Loading branch information
panbingkun authored and zhengruifeng committed Dec 25, 2023
1 parent d85ad1c commit d1a333d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ jobs:
export TERM=vt100
# Hive "other tests" test needs larger metaspace size based on experiment.
if [[ "$MODULES_TO_TEST" == "hive" ]] && [[ "$EXCLUDED_TAGS" == "org.apache.spark.tags.SlowHiveTest" ]]; then export METASPACE_SIZE=2g; fi
// SPARK-46283: should delete the following env replacement after SPARK 3.x EOL
# SPARK-46283: should delete the following env replacement after SPARK 3.x EOL
if [[ "$MODULES_TO_TEST" == *"streaming-kinesis-asl"* ]] && [[ "${{ inputs.branch }}" =~ ^branch-3 ]]; then
MODULES_TO_TEST=${MODULES_TO_TEST//streaming-kinesis-asl, /}
fi
Expand Down

0 comments on commit d1a333d

Please sign in to comment.