This repository has been archived by the owner on Mar 21, 2018. It is now read-only.
Refactor extensions with a more functional approach #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't automatically monkey patch
don't automatically monkey patch
|
Do this now. Nothing to wait on. |
|
@cbandy This is only two of the modules, the PR isn't done. |
|
@reset Any progress on this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All extensions right now are written as modules to be included in another class. They should be re-written to expose class functions which take an instance of the object they would be extending.
This will allow us to make the monkey patching optional and to access the extensions in a more deliberate way.